search

aws / aws-iot-device-sdk-js

SDK for connecting to AWS IoT from a device using JavaScript/Node.js
Apache License 2.0
964 stars 384 forks source link

thingShadow#unsubscribe #67

Closed linqFR closed 7 years ago

linqFR commented 8 years ago

in awsIot.thingShadow#unsubscribe(topic, [options], [callback]),please precise that this is not identical to mqtt.Client#unsubscribe() ! It does not accept topic array !

johnrotach commented 8 years ago

Hello @linqOxelar,

You are correct, unsubscribe should support the same functionality as the underlying client (such as https://github.com/aws/aws-iot-device-sdk-js/blob/master/device/index.js#L693). We'll fix this and update this issue when the fix is released.

John AWS IoT

fengsongAWS commented 7 years ago

Fix in v1.0.14

linqFR commented 7 years ago

@fengsongAWS - could be more efficient to correct / update online documentation before closing an issue : as usual, online AWS is not precise, hence incorrect !

if awsIot.thingShadow#unsubscribe() is now like mqtt.Client#unsubscribe(), awsIot.thingShadow#unsubscribe(topic, [options], [callback]) must become awsIot.thingShadow#unsubscribe(topic/topic array/topic object, [options], [callback])