refactor: simplify node npm workflow conditionals

aws / aws-lambda-builders

Python library to compile, build & package AWS Lambda functions for several runtimes & framework

Apache License 2.0

334 stars 139 forks source link

refactor: simplify node npm workflow conditionals #458

Closed torresxb1 closed 1 year ago

torresxb1 commented 1 year ago

Issue #, if available:

Description of changes: Currently there are a few nested conditions in the workflow. This PR refactors to remove some nesting and try to simplify the logic.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sriram-mv commented 1 year ago

Note: I still believe this requires an overall refactor, there are repeated statements and branching logic that looks identical even though the state that they operate on could be different.

torresxb1 commented 1 year ago

Created an internal ticket to suggest further, bigger, refactoring improvements. Merging this one.