fix: Ignore flags not relevant to esbuild

aws / aws-lambda-builders

Python library to compile, build & package AWS Lambda functions for several runtimes & framework

Apache License 2.0

337 stars 139 forks source link

fix: Ignore flags not relevant to esbuild #510

Closed mildaniel closed 1 year ago

mildaniel commented 1 year ago

Issue #, if available: https://github.com/aws/aws-sam-build-images/issues/90 https://github.com/aws/aws-sam-cli/issues/5236

Description of changes: Since making the change to accept any flags for esbuild, there is an issue with esbuild trying to use flags that are not related to it. This changes forces the esbuild command builder to ignore those unrelated flags.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mildaniel commented 1 year ago

Change seems reasonable to me.

Are we sure these are the only two (use_npm_ci, entry_points)?

Yup, should be just these.