aws / aws-lambda-builders

Python library to compile, build & package AWS Lambda functions for several runtimes & framework

Apache License 2.0

334 stars 139 forks source link

fix: Decoding non-unicode characters raises unhandled exception #554

Closed mildaniel closed 11 months ago

mildaniel commented 11 months ago

Issue #, if available:

548

https://github.com/aws/aws-sam-cli/issues/2317

Description of changes: There are times when Lambda Builders will attempt to decode command output that contains unsupported characters. In these events, the program will crash with an unhandled exception. Instead, complete the build and log a message explaining that the output couldn't be decoded.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sriram-mv commented 11 months ago

LGTM, though there are windows failures that need to be addressed.