Closed PeterKneale closed 2 years ago
Good catch, you are right request
is too common and we should avoid collisions.
PR is merged and will go out in the next release. Thanks for the great feedback!
Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.
@normj tested in 0.5.1-preview
- working nicely
Describe the bug
When naming a parameter to a lambda function
request
, the source generators fail.request
is such common name for a single request parameter that others are bound to hit this issue.Expected Behavior
I expect the below signature to be valid
Current Behavior
Using this signature results in an error when compiling
1>........\Stores\Amazon.Lambda.Annotations.SourceGenerator\Amazon.Lambda.Annotations.SourceGenerator.Generator\CreateStore_Execute_Generated.g.cs(40,106): Error CS1061 : 'CreateStoreRequest' does not contain a definition for 'Body' and no accessible extension method 'Body' accepting a first argument of type 'CreateStoreRequest' could be found (are you missing a using directive or an assembly reference?)
1>........\Stores\Amazon.Lambda.Annotations.SourceGenerator\Amazon.Lambda.Annotations.SourceGenerator.Generator\CreateStore_Execute_Generated.g.cs(44,55): Error CS1061 : 'CreateStoreRequest' does not contain a definition for 'Body' and no accessible extension method 'Body' accepting a first argument of type 'CreateStoreRequest' could be found (are you missing a using directive or an assembly reference?)
1>------- Finished building project: Stores. Succeeded: False. Errors: 3.