search

aws / aws-lambda-nodejs-runtime-interface-client

Apache License 2.0
179 stars 56 forks source link

Allow building on macos #4

Closed mraerino closed 3 years ago

mraerino commented 3 years ago

Issue #, if available: https://github.com/awslabs/aws-lambda-cpp/issues/52

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

carlzogh commented 3 years ago

Hey @mraerino - thanks for your contribution. However, I don't think this project is the right place to be making core changes to the aws-lambda-cpp project, especially since it seems that disabling builds on MacOS was a deliberate decision from the maintainers to avoid building and packaging functions on a non-Linux host when they are always going to run on Linux in Lambda.

Lambda only runs on Linux. So why bother with maintaining the code on macOS? You can think of it as a fail-fast mechanism to prevent people from building and packaging a Lambda on macOS only to then see it fail when deployed.

see #34 for a similar question/answer.

ref. https://github.com/awslabs/aws-lambda-cpp/issues/52#issuecomment-516506872

mraerino commented 3 years ago

that's fine. https://github.com/aws/aws-lambda-nodejs-runtime-interface-client/pull/8 would be the better approach imho