search

aws / aws-lambda-nodejs-runtime-interface-client

Apache License 2.0
180 stars 56 forks source link

adding support for .cjs file extensions for user function #63

Closed miki725 closed 1 year ago

miki725 commented 1 year ago

Within ES modules (type is module inside package.json), if you try to either:

require('file')
require('file.js')

it does not allow that as imports should be used within ES modules. The only way to use require() is to explicitly require .cjs file which explicitly indicates that path is a CommonJS file, not ESM:

require('file.cjs')

Issue #, if available:

partly related to https://github.com/aws/aws-lambda-nodejs-runtime-interface-client/issues/44

Description of changes:

This change allows to require .cjs files when a user function is being searched. I would imagine eventually this library would need to fully support ES modules as per https://github.com/aws/aws-lambda-nodejs-runtime-interface-client/issues/44 however this diff will allow people to use lambdas within ES modules if they have .cjs lambda files.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

andclt commented 1 year ago

Hi @miki725, I think this has been fixed with https://github.com/aws/aws-lambda-nodejs-runtime-interface-client/pull/70. Feel free to reopen the issue if it is not accurate.