search

aws / aws-lambda-python-runtime-interface-client

Apache License 2.0
261 stars 74 forks source link

test vs tests (singular/plural) #20

Closed wagdav closed 3 years ago

wagdav commented 3 years ago

The tests of this package are located under the test (singular) directory. The project's setup.py, however contains the line:

  test_suite="tests",

using plural form.

This makes the command: python setup.py test fail.

The fix could be either: 1) Rename the directory test → tests 2) Fix the names in setup.py (The packages directive also uses the plural form)

I'm happy to submit a PR with the preferred solution. My personal preference would be 1).

carlzogh commented 3 years ago

Thanks for reporting this @wagdav - and good catch! Yes please, feel free to contribute this fix in a PR (also making sure that all appropriate references to the test directory are updated, of course)

wagdav commented 3 years ago

@carlzogh I opened PR #21 as discussed, please take a look. Thanks.