search

aws / aws-lambda-python-runtime-interface-client

Apache License 2.0
258 stars 73 forks source link

Update importlib-metadata to newest version #61

Open iwanbolzern opened 2 years ago

iwanbolzern commented 2 years ago

Hi all,

Is it possible to update the importlib-metadata dependency, so that it is again compatible with the newest version. Please see the error bellow if you try to use awslambdaric e.g. together with keyring (output of poetry):

Because no versions of awslambdaric match >2.0.0,<3.0.0 and awslambdaric (2.0.0) depends on importlib-metadata (>=2.0,<3.0), awslambdaric (>=2.0.0,<3.0.0) requires importlib-metadata (>=2.0,<3.0). Because keyring (23.2.1) depends on importlib-metadata (>=3.6) and no versions of keyring match >23.2.1,<24.0.0, keyring (>=23.2.1,<24.0.0) requires importlib-metadata (>=3.6).

Thanks in advance and all the best, Iwan

DavidCain commented 2 years ago

I put out a one-line PR to fix, but it turns out that this package actually doesn't need importlib-metadata at all!

Removing the importlib-metadata dependency will allow using this package with Python 3.7 (or an older, EOL Python) and a newer version of importlib-metadata.

iwanbolzern commented 2 years ago

@DavidCain Thanks for looking into this and fixing it!

DavidCain commented 2 years ago

Not fixed yet, sadly - needs maintainers to see the PR and release a new version of the package. But I appreciate it all the same. 😄

But for now, you should at least be able to work around this issue by using Python 3.8 or newer with awslambdaric!

tylertrussell commented 1 year ago

It looks like this is now merged-in, and all we need is a new version of the package released.

Who do we need to ask to make that happen?