aws / aws-lambda-python-runtime-interface-client

Apache License 2.0
258 stars 73 forks source link

Update aws-lambda-cpp to 0.2.7 #67

Open tl-hbk opened 2 years ago

tl-hbk commented 2 years ago

Was having the following issue when building https://github.com/awslabs/aws-lambda-cpp/issues/93 which is fixed in aws-lambda-cpp 0.2.7

The following patches were deleted as they were already merged upstream in aws-lambda-cpp

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tl-hbk commented 2 years ago

Unrelated but when I ran update_deps.sh the download for curl was broken. It seems like it works when the periods in the version string are replaced with underscores in the url

https://github.com/curl/curl/archive/curl-7.78.0.tar.gz - broken https://github.com/curl/curl/archive/curl-7_78_0.tar.gz - working

EDIT: It does seem like the second url is pointing to a different archive than what's checked into git. What's in git seems to be the archive at https://github.com/curl/curl/releases/download/curl-7_78_0/curl-7.78.0.tar.gz

zsombor-balogh commented 2 years ago

Unrelated but when I ran update_deps.sh the download for curl was broken. It seems like it works when the periods in the version string are replaced with underscores in the url

https://github.com/curl/curl/archive/curl-7.78.0.tar.gz - broken https://github.com/curl/curl/archive/curl-7_78_0.tar.gz - working

EDIT: It does seem like the second url is pointing to a different archive than what's checked into git. What's in git seems to be the archive at https://github.com/curl/curl/releases/download/curl-7_78_0/curl-7.78.0.tar.gz

Thanks for pointing out, it's been addressed.

zsombor-balogh commented 2 years ago

Thank you for your contribution! It looks like deps/versions is conflicting with a recent libcurl update, would you mind resolving the conflict?

tl-hbk commented 2 years ago

@zsombor-balogh resolved the conflict

tl-hbk commented 2 years ago

Build errors seem to be related to this https://github.com/awslabs/aws-lambda-cpp/issues/124