Closed DavidCain closed 2 years ago
I do recognize that this PR should likely increment __version__
and add some release notes, but that's presuming that you choose to accept the change and release it with 2.0.5 (or 2.1.0, or whatever the next release is).
Maintainers - is there any chance this (one-line) PR can get some eyes? It should be exceedingly safe, and for many people will fix the ability to use awslambdaric
on Python 3.7.
@carlzogh @smirnoal and/or @SukanyaHanumanthu - sorry to ping, but is there any chance you could take a look?
@keshayad - sorry to ping you, but can we get this released into PyPi sometime soon? it's preventing us from updating some important dependencies.
@keshayad, I also have the same request as @tylertrussell. Could you please release this to PyPI?
The pinning of importlib-metadata~=2.0 is also preventing us from updating some important dependencies.
This should complete a previous attempt to remove dependency on the package, unblocking use of
awslambdaric
in projects that use a newer version ofimportlib-metadata
. Version 2 ofimportlib-metadata
is reasonably old - version 4.4 is present in Python 3.10 for instance.Motivation for the change
I think issue #61 covers it well, but essentially it becomes difficult to use
awslambdaric
in a virtualenv with other dependencies that expect a newer version ofimportlib-metadata
:awslambdaric
isn't supposed to needimportlib-metadata
anywayPrevious work (in August of 2021, with version 1.2.2) removed all dependency on the
importlib-metadata
package, but accidentally leftimportlib-metadata
as a full dependency of this package:Most recent version still has
importlib-metadata
dependencyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
I've read
CONTRIBUTING.md
and believe this should be all that's needed for a PR, but please let me know if I'm missing anything!