search

aws / aws-lc-rs

aws-lc-rs is a cryptographic library using AWS-LC for its cryptographic operations. The library strives to be API-compatible with the popular Rust library named ring.
Other
247 stars 40 forks source link

Split CI configuration across multiple files #316

Closed justsmth closed 5 months ago

justsmth commented 5 months ago

Issues:

N/A

Description of changes:

Split CI configuration across multiple files.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c5bb144) 95.91% compared to head (09a6e4c) 95.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #316 +/- ## ======================================= Coverage 95.91% 95.91% ======================================= Files 60 60 Lines 8522 8522 ======================================= Hits 8174 8174 Misses 348 348 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

WillChilds-Klein commented 5 months ago

were any changes made to the contents, or is this strictly copy/paste from one file to a few others?

also, should some of these GHA jobs be required to pass before PRs can be merged?

justsmth commented 5 months ago

were any changes made to the contents, or is this strictly copy/paste from one file to a few others?

Yeah, the only change to the jobs is that I added a "fips" run for the coverage job. Otherwise, no changes to the jobs.

also, should some of these GHA jobs be required to pass before PRs can be merged?

I agree. After this gets merged, we need to reconfigure the "required" CI jobs. (The GitHub UI for managing these has been painful to use.)