search

aws / aws-lc-rs

aws-lc-rs is a cryptographic library using AWS-LC for its cryptographic operations. The library strives to be API-compatible with the popular Rust library named ring.
Other
247 stars 40 forks source link

Windows: include `printenv.bat` in cargo releases #332

Closed ctz closed 5 months ago

ctz commented 5 months ago

Issues:

Working on https://github.com/rustls/rustls/actions/runs/7694846379/job/20966481181 build breakage

Testing:

I ran cargo package locally, but I haven't managed to test this in a meaningful way.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

justsmth commented 5 months ago

Thanks! This is at least the second time we've been bit by forgetting to "include" Windows-specific files in our package. We need a better mechanism for detecting this.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f31bee9) 95.82% compared to head (9c2a931) 95.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #332 +/- ## ======================================= Coverage 95.82% 95.82% ======================================= Files 62 62 Lines 8025 8025 ======================================= Hits 7690 7690 Misses 335 335 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.