search

aws / aws-lc-rs

aws-lc-rs is a cryptographic library using AWS-LC for its cryptographic operations. The library strives to be API-compatible with the popular Rust library named ring.
Other
247 stars 40 forks source link

Improve exposure of dry-run publish failures #333

Closed justsmth closed 5 months ago

justsmth commented 5 months ago

Issues:

N/A

Description of changes:

Call-outs:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

justsmth commented 5 months ago

I'm confused as to why the CI succeeded here: https://github.com/aws/aws-lc-rs/actions/runs/7713821796/job/21024672650?pr=333#step:9:99

The "checkout" action does a merge (so it has the fix): https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges

justsmth commented 5 months ago

The failure I was hoping for: https://github.com/aws/aws-lc-rs/actions/runs/7714541187/job/21027029187?pr=333#step:9:110

...
   Compiling aws-lc-fips-sys v0.12.1 (D:\a\aws-lc-rs\aws-lc-rs\target\package\aws-lc-fips-sys-0.12.1)
error: failed to run custom build command for `aws-lc-fips-sys v0.12.1 (D:\a\aws-lc-rs\aws-lc-rs\target\package\aws-lc-fips-sys-0.12.1)`
note: To improve backtraces for build dependencies, set the CARGO_PROFILE_DEV_BUILD_OVERRIDE_DEBUG=true environment variable to enable debug information generation.

Caused by:
  process didn't exit successfully: `D:\a\aws-lc-rs\aws-lc-rs\target\package\aws-lc-fips-sys-0.12.1\target\debug\build\aws-lc-fips-sys-af43f87486267e88\build-script-main` (exit code: 101)
  --- stdout
  cargo:rustc-cfg=use_bindgen_generated

  --- stderr

  thread 'main' panicked at builder\cmake_builder.rs:106:30:
  Failed to run vccarsall.bat.