codecov-commenter
commented
5 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3e194ee) 95.83% compared to head (4cf7dd5) 95.83%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #335 +/- ## ======================================= Coverage 95.83% 95.83% ======================================= Files 60 60 Lines 7868 7868 ======================================= Hits 7540 7540 Misses 328 328 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description of changes:
This change exports the underlying
*-syscrate in theaws-lc-rscrate. This is needed for a couple of reasons:aws-lc-sys = "0.12". In s2n-quic, we depend onaws-lc-rs = ">=1.5". When a newaws-lc-rsversion is published, then we get conflicting resolutions and end up with 2 copies ofaws-lc-sys. Symbol prefixing is currently not working well enough to prevent conflicts.aws-lc-sysdirectly, they'll have to duplicate thefips/non-fipsfeature switching logic that's already present inaws-lc-rs. This logic is a bit complicated so it'd be nice to have it implemented in a single location.With this change, s2n-tls will instead depend on
aws-lc-rs = "1". This will avoid issues of preventing it using the latest aws-lc-sys crates on newer releases. It'll also make it easier to pick upfipsbuilds, since we rely on the logic inaws-lc-rs.Call-outs:
I did some minor refactoring to the build scripts to try and make it a bit clearer.
Testing:
I've expanded the
sys-testingcrate to include the new functionality.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.