search

aws / aws-lc-rs

aws-lc-rs is a cryptographic library using AWS-LC for its cryptographic operations. The library strives to be API-compatible with the popular Rust library named ring.
Other
236 stars 40 forks source link

feat: support openharmony platform #434

Closed richerfu closed 3 weeks ago

richerfu commented 4 weeks ago

Issues:

Description of changes:

When using cmake for building, make sure to include the cmake files and parameters that openharmony needs to ensure a successful build.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

justsmth commented 4 weeks ago

Are there any tools (similar to cross-rs or cargo-xwin) that would allow us to test compilation to an OpenHarmony target in our CI?

codecov-commenter commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.67%. Comparing base (c358484) to head (45247cb). Report is 22 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #434 +/- ## ========================================== - Coverage 95.80% 92.67% -3.13% ========================================== Files 61 61 Lines 8143 8174 +31 Branches 0 8174 +8174 ========================================== - Hits 7801 7575 -226 - Misses 342 357 +15 - Partials 0 242 +242 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

richerfu commented 4 weeks ago

Are there any tools (similar to cross-rs or cargo-xwin) that would allow us to test compilation to an OpenHarmony target in our CI?

No, in fact, there is currently no very suitable way to run code whose target architecture is openharmony, even rust or openharmony officially does not have it yet. When there is a suitable way, I will try to add the corresponding CI to support