aws-lc-sys build should check for minimal bindgen version

aws / aws-lc-rs

aws-lc-rs is a cryptographic library using AWS-LC for its cryptographic operations. The library strives to be API-compatible with the popular Rust library named ring.

Other

320 stars 49 forks source link

aws-lc-sys build should check for minimal bindgen version #484

Closed elmarco closed 2 months ago

elmarco commented 3 months ago

During the build of a project that depends on rustls, and includes aws-lc-sys:

bindgen-STDERR: error: invalid value '1.59' for '--rust-target ': Got an invalid rust target. Accepted values are of the form "1.0" or "nightly".

I used to have bindgen 0.65.1 installed. After upgrading to 0.69.4, issue disappeared.

justsmth commented 3 months ago

Hello! Thanks for reporting this.

I put up a PR to help improve our handling of this: https://github.com/aws/aws-lc-rs/pull/494

justsmth commented 2 months ago

This is resolved with the release of aws-lc-rs v1.9.0.