aws / aws-lc-rs

aws-lc-rs is a cryptographic library using AWS-LC for its cryptographic operations. The library strives to be API-compatible with the popular Rust library named ring.
Other
318 stars 49 forks source link

Support for compressed and X.509 public key format #498

Closed skmcgrail closed 3 months ago

skmcgrail commented 3 months ago

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 89.47368% with 30 lines in your changes missing coverage. Please review.

Project coverage is 92.56%. Comparing base (c358484) to head (f9af638). Report is 61 commits behind head on main.

Files Patch % Lines
aws-lc-rs/src/ec.rs 88.07% 5 Missing and 8 partials :warning:
aws-lc-rs/src/agreement.rs 91.42% 7 Missing and 5 partials :warning:
aws-lc-rs/src/agreement/ephemeral.rs 88.57% 4 Missing :warning:
aws-lc-rs/src/ec/key_pair.rs 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #498 +/- ## ========================================== - Coverage 95.80% 92.56% -3.24% ========================================== Files 61 67 +6 Lines 8143 9136 +993 Branches 0 9136 +9136 ========================================== + Hits 7801 8457 +656 - Misses 342 417 +75 - Partials 0 262 +262 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctz commented 2 months ago

I think ideally this would have been done with a separate API (eg, agreement::ECDH_P256_COMPRESSED, agreement:ECDH_P256_AUTODETECT, perhaps). As it is, this is not compatible with: