Update aws-lc-sys, align w/ AWS-LC v1.34.2

aws / aws-lc-rs

aws-lc-rs is a cryptographic library using AWS-LC for its cryptographic operations. The library strives to be API-compatible with the popular Rust library named ring.

Other

320 stars 49 forks source link

Update aws-lc-sys, align w/ AWS-LC v1.34.2 #509

Closed justsmth closed 2 months ago

justsmth commented 3 months ago

Description of changes:

Aligns aws-lc-sys v0.21.0 w/ AWS-LC v1.34.2
- Adds support for a AWS_LC_SYS_C_STD environment variable to determine which C standard to use.
- For platforms that build using "cc" (instead of CMake), the build defaults to using the C11 standard.

Call-outs:

Automated workflow is here: https://github.com/aws/aws-lc-rs/actions/runs/10598652101
Only first commit is manual.
The C11 build doesn't contain the CRYPTO_refcount_dec_and_test_zero or CRYPTO_refcount_inc symbols. We need these symbols to be prefixed for C99 build. Thus, for some targets in the symbol collection step of the automation are being forced to use a C99 build.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.52%. Comparing base (c358484) to head (99c6931). Report is 78 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #509 +/- ## ========================================== - Coverage 95.80% 92.52% -3.28% ========================================== Files 61 67 +6 Lines 8143 9277 +1134 Branches 0 9277 +9277 ========================================== + Hits 7801 8584 +783 - Misses 342 422 +80 - Partials 0 271 +271 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zh-jq commented 2 months ago

Is it possible to update bindgen to 0.70 for aws-lc-sys v0.21.0?

justsmth commented 2 months ago

Is it possible to update bindgen to 0.70 for aws-lc-sys v0.21.0?

Unfortunately, bindgen v0.70.x has an MSRV of 1.70, whereas our crates still maintain an MSRV of 1.63. (Our current dependency is on bindgen v0.69.4 which has an MSRV of 1.60.)

When we update our MSRV again, we plan to also update many of our dependencies to more recent versions.