aws / aws-lc-rs

aws-lc-rs is a cryptographic library using AWS-LC for its cryptographic operations. The library strives to be API-compatible with the popular Rust library named ring.
Other
320 stars 49 forks source link

bump cc version to fix build #518

Closed ctz closed 2 months ago

ctz commented 2 months ago

Description of changes:

This fixes a downstream build failure:

   Compiling aws-lc-sys v0.21.0
error[E0308]: mismatched types
   --> /home/jbp/.cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.21.0/builder/cc_builder.rs:128:31
    |
128 |                   cc_build.flag(format!(
    |  _______________________________^
129 | |                     "-ffile-prefix-map={}=",
130 | |                     self.manifest_dir.display()
131 | |                 ));
    | |_________________^ expected `&str`, found `String`
    |
    = note: this error originates in the macro `format` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0308`.
error: could not compile `aws-lc-sys` (build script) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

That is because my Cargo.lock contains 1.0.90, aws-lc-sys's Cargo.toml specifies ^1.0.83, but the build script requires a cc change first introduced in 1.0.100.

(The build failure is easy to work around, with just cargo update -p cc --precise 1.0.100).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

justsmth commented 2 months ago

Thanks for the PR!

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.52%. Comparing base (c358484) to head (f143744). Report is 74 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #518 +/- ## ========================================== - Coverage 95.80% 92.52% -3.28% ========================================== Files 61 67 +6 Lines 8143 9277 +1134 Branches 0 9277 +9277 ========================================== + Hits 7801 8584 +783 - Misses 342 422 +80 - Partials 0 271 +271 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.