search

aws / aws-lc-rs

aws-lc-rs is a cryptographic library using AWS-LC for its cryptographic operations. The library strives to be API-compatible with the popular Rust library named ring.
Other
318 stars 49 forks source link

Update FreeBSD version to 14.1 in cross compiling workflow #536

Closed yonas closed 2 months ago

yonas commented 2 months ago

The latest production release of FreeBSD is 14.1

Issues:

Resolves #535

Description of changes:

Update from 13.2 to 14.1

Testing:

Check that the cross.yaml build works for FreeBSD.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

justsmth commented 2 months ago

Maybe we should test FreeBSD w/ 12.4, 13.4 and 14.1? The action we use appears to support all three: https://github.com/vmactions/freebsd-vm/tree/main/conf

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.52%. Comparing base (c358484) to head (850fa77). Report is 80 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #536 +/- ## ========================================== - Coverage 95.80% 92.52% -3.28% ========================================== Files 61 67 +6 Lines 8143 9277 +1134 Branches 0 9277 +9277 ========================================== + Hits 7801 8584 +783 - Misses 342 422 +80 - Partials 0 271 +271 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yonas commented 2 months ago

@justsmth Thanks, I've updated to build against 13.4 and 14.1, since 12.4 is no longer supported by the FreeBSD Foundation.