search

aws / aws-lc-rs

aws-lc-rs is a cryptographic library using AWS-LC for its cryptographic operations. The library strives to be API-compatible with the popular Rust library named ring.
Other
320 stars 49 forks source link

Handle spaces in source/build paths #608

Closed justsmth closed 6 days ago

justsmth commented 1 week ago

Issues:

Addresses:

Description of changes:

Testing:

New tests added.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.72%. Comparing base (c358484) to head (087dec7). Report is 121 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #608 +/- ## ========================================== - Coverage 95.80% 92.72% -3.08% ========================================== Files 61 67 +6 Lines 8143 9768 +1625 Branches 0 9768 +9768 ========================================== + Hits 7801 9057 +1256 - Misses 342 426 +84 - Partials 0 285 +285 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

justsmth commented 1 week ago

The "Spaces in path - macos-14-xlarge - FIPS: 1" job is failing. The fix depends upon this upstream PR:

Other failures are being address on another PR: