search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

Enable x86_64 AES-GCM proof in AWS-LC CI #1592

Closed pennyannn closed 1 month ago

pennyannn commented 1 month ago

Description of changes:

This PR enables unbounded SAW proofs for AES-GCM on x86_64 (without AVX-512).

Specifically, this PR:

  1. Adds building and pushing of a new docker image: ubuntu-20.04_clang-10x_formal-verification-saw-x86_64-aes-gcm
  2. Updates relative files to add a new build ubuntu2004_clang10x_formal_verification_saw_x86_64_aes_gcm in linux-x86 runs

Call-outs:

The AES-GCM proof requires using a version of SAW that is incompatible with existing SAW proofs. We solve this problem by using a separate workflow for the AES-GCM proof.

Testing:

CI run succeeds.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.92%. Comparing base (fc06ecb) to head (651ea95).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1592 +/- ## ========================================== + Coverage 77.90% 77.92% +0.01% ========================================== Files 561 561 Lines 94632 94632 Branches 13604 13604 ========================================== + Hits 73725 73739 +14 + Misses 20315 20301 -14 Partials 592 592 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.