search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

add support for X509_CRL_http_nbio #1596

Closed samuel40791765 closed 1 month ago

samuel40791765 commented 1 month ago

Issues:

Resolves CryptoAlg-1648

Description of changes:

X509_CRL_http_nbio is the last API needed to support the AzureSDK after implementation of https://github.com/aws/aws-lc/commit/7ef93cb8b9305405f619ab7639e1e7d0d3d4614c. It's a simple wrapper around an existing API, so might as well add support so we can resolve the ticket.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

justsmth commented 1 month ago

Something is missing in this PR...

https://github.com/aws/aws-lc/actions/runs/9086321401/job/24971726741?pr=1596#step:3:303

In file included from /home/runner/work/aws-lc/aws-lc/include/openssl/ocsp.h:15,
                 from /home/runner/work/aws-lc/aws-lc/crypto/ocsp/internal.h:10,
                 from /home/runner/work/aws-lc/aws-lc/crypto/ocsp/ocsp_asn.c:13:
/home/runner/work/aws-lc/aws-lc/include/openssl/x509.h:815:39: error: unknown type name ‘OCSP_REQ_CTX’
  815 | OPENSSL_EXPORT int X509_CRL_http_nbio(OCSP_REQ_CTX *rctx, X509_CRL **pcrl);
      |                                       ^~~~~~~~~~~~
samuel40791765 commented 1 month ago

Something is missing in this PR...

My bad haha

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.04%. Comparing base (92bf532) to head (2c34afe).

Files Patch % Lines
crypto/x509/x_all.c 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1596 +/- ## ======================================= Coverage 78.03% 78.04% ======================================= Files 562 562 Lines 94556 94558 +2 Branches 13574 13574 ======================================= + Hits 73786 73795 +9 + Misses 20175 20171 -4 + Partials 595 592 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.