search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

sha: Move AArch64/X86-64 dispatching to C. #1625

Open justsmth opened 4 weeks ago

justsmth commented 4 weeks ago

Upstream Commit: 10c24cb

Take a step towards removing all dispatching logic from assembly for AArch64 and X86-64.

Change-Id: I1c965012e81837ff228c810d54e730c525cad54f Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/64208 Reviewed-by: Bob Beck bbe@google.com Commit-Queue: David Benjamin davidben@google.com Reviewed-by: David Benjamin davidben@google.com

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 43.39623% with 30 lines in your changes missing coverage. Please review.

Project coverage is 78.12%. Comparing base (b765d4a) to head (5baec02).

Files Patch % Lines
crypto/fipsmodule/sha/internal.h 35.00% 13 Missing :warning:
crypto/fipsmodule/sha/sha1.c 40.00% 9 Missing :warning:
crypto/fipsmodule/sha/sha256.c 50.00% 6 Missing :warning:
crypto/fipsmodule/sha/sha512.c 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1625 +/- ## ========================================== - Coverage 78.13% 78.12% -0.01% ========================================== Files 562 562 Lines 94638 94670 +32 Branches 13573 13581 +8 ========================================== + Hits 73941 73962 +21 - Misses 20103 20114 +11 Partials 594 594 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

justsmth commented 2 weeks ago

PR for reverting a commit that this depends on: https://github.com/aws/aws-lc/pull/1656

nebeid commented 1 week ago

This PR can include the skipped commit https://github.com/google/boringssl/commit/f5e0c8f92a22679b0cd8d24d0d670769c1cc07f3 (in upstream merge 2024-06-24). The commit including conflict resolution is in the attached file. chacha-move-dispatch-bsslf5e0c8f.patch We can add to the commits or the PR description that changes to crypto/internal.h upstream are made in crypto/fipsmodule/cpucap/internal.h in aws-lc.