Use 'nasm' not 'yasm' - Githubissues

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.

Other

258 stars 105 forks source link

Use 'nasm' not 'yasm' #1630

Closed justsmth closed 3 weeks ago

justsmth commented 3 weeks ago

Issues:

Resolves https://github.com/aws/aws-lc-rs/issues/425

Context:

CMake will attempt to use the YASM assembler if found.

YASM is unable to handle our AVX-512 assembly:

...\aesni-xts-avx512.asm:136: error: undefined symbol `zmm25' (first use)

Change:

This change has CMake locate the "nasm" executable, then sets that as the CMAKE_ASM_NASM_COMPILER.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.