search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

add support for EC_POINT_bn2point #1645

Open samuel40791765 opened 1 week ago

samuel40791765 commented 1 week ago

Issues:

Addresses CryptoAlg-1715

Description of changes:

Ruby happens to consume this. This is deprecated in OpenSSL 3.0 and I've marked it likewise in AWS-LC as well. Although Ruby has generally moved off of deprecated 3.0 APIs, they still depend on this and later versions like 3.2 and 3.3 have not removed support for this either.

Call-outs:

N/A

Testing:

Tests built upon original tests for EC_POINT_point2bn.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 6 days ago

Codecov Report

Attention: Patch coverage is 87.50000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.19%. Comparing base (3da2c4a) to head (e5cc14e).

Files Patch % Lines
crypto/ec_extra/ec_asn1.c 66.66% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1645 +/- ## ========================================== - Coverage 78.21% 78.19% -0.02% ========================================== Files 571 571 Lines 95405 95458 +53 Branches 13705 13705 ========================================== + Hits 74621 74647 +26 - Misses 20173 20201 +28 + Partials 611 610 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.