search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

Added constant_time_select array and entry_from_table #1660

Closed dkostic closed 1 week ago

dkostic commented 1 week ago

Issues:

N/A

Description of changes:

Added constant_time_select array and entry_from_table.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.22%. Comparing base (4368aaa) to head (ce72d0c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1660 +/- ## ========================================== - Coverage 78.22% 78.22% -0.01% ========================================== Files 566 566 Lines 95165 95183 +18 Branches 13661 13663 +2 ========================================== + Hits 74442 74453 +11 - Misses 20127 20136 +9 + Partials 596 594 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dkostic commented 1 week ago

I'm guessing this is to be used with C code, right?

yes, I plan to use the new function in EC scalar multiplication implementation to select points from precomputed table in constant time.