search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

Update ACVP SHAKE test implementations #1663

Closed billbo-yang closed 4 days ago

billbo-yang commented 1 week ago

Issues:

Needed to move forward with ACVP testing in the future.

Description of changes:

Our SHAKE ACVP test implementations and registrations don't work with the current version of NIST's server, so this updates our logic to match what the server expects and fixes the following for SHAKE in our ACVP tool:

Call-outs:

N/A

Testing:

SHA1/2/3 and SHAKE now properly pass tests run against the NIST demo server.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.22%. Comparing base (b2bbd9c) to head (dfdace5). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1663 +/- ## ======================================= Coverage 78.22% 78.22% ======================================= Files 566 566 Lines 95193 95185 -8 Branches 13665 13663 -2 ======================================= - Hits 74465 74462 -3 + Misses 20133 20129 -4 + Partials 595 594 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.