search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

ec_nistp table generation for scalar multiplication #1669

Open dkostic opened 5 days ago

dkostic commented 5 days ago

Issues:

N/A

Description of changes:

Generating the precomputed table for scalar multiplication for curves P-384 and P-521 was implemented for each curve separately. This commit refactors the code such that a single implementation can be used with both curves. It is a step towards moving the whole scalar multiplication code to ec_nistp.c.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.18%. Comparing base (05d3bfd) to head (f3e838e). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1669 +/- ## ========================================== - Coverage 78.27% 78.18% -0.09% ========================================== Files 567 571 +4 Lines 95227 95411 +184 Branches 13671 13701 +30 ========================================== + Hits 74538 74599 +61 - Misses 20095 20200 +105 - Partials 594 612 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.