Open samuel40791765 opened 5 days ago
Attention: Patch coverage is 81.03448%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 78.26%. Comparing base (
21c5e48
) to head (0e319eb
).
Files | Patch % | Lines |
---|---|---|
crypto/ec_extra/ec_asn1.c | 57.89% | 8 Missing :warning: |
crypto/pem/pem_all.c | 86.95% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues:
Addresses
CryptoAlg-1715
Description of changes:
Ruby depends on reading/writing PEM files that are defined as
EcpkParameters
(See RFC 3279 for more details).EcpkParameters
actually just refer to potential different ways of serializing EC Groups and we already have basic support for this. OpenSSL's implementation ofd2i/i2d_ECParameters
actually callsd2i/i2d_ECPKParameters
internally.d2i/i2d_ECParameters
and worked them into the new functions. Apparently we only support parsing named curves or explicitly encoded versions of them, so I've documented that and followed the same pattern. No new parsing logic has been added forEC_GROUP
s.Call-outs:
crypto/pem/pem_lib.c
was taken from OpenSSL: https://github.com/openssl/openssl/commit/205957405d08ef199e6ab654e333a627bbca9ccc It was worth taking, so the call toPEM_write_bio
could be cleaner.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.