aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

Add support for parsing ECPKParameter PEM files #1670

Open samuel40791765 opened 5 days ago

samuel40791765 commented 5 days ago

Issues:

Addresses CryptoAlg-1715

Description of changes:

Ruby depends on reading/writing PEM files that are defined as EcpkParameters (See RFC 3279 for more details).EcpkParameters actually just refer to potential different ways of serializing EC Groups and we already have basic support for this. OpenSSL's implementation of d2i/i2d_ECParameters actually calls d2i/i2d_ECPKParameters internally.

Call-outs:

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 81.03448% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.26%. Comparing base (21c5e48) to head (0e319eb).

Files Patch % Lines
crypto/ec_extra/ec_asn1.c 57.89% 8 Missing :warning:
crypto/pem/pem_all.c 86.95% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1670 +/- ## ======================================= Coverage 78.26% 78.26% ======================================= Files 567 567 Lines 95238 95290 +52 Branches 13673 13678 +5 ======================================= + Hits 74535 74579 +44 - Misses 20109 20115 +6 - Partials 594 596 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.