search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

Better support legacy DES customers #1671

Closed andrewhop closed 2 days ago

andrewhop commented 5 days ago

Issues:

Addresses CryptoAlg-2421

Description of changes:

No one should start using these DES functions, or continue using DES in general. However, for legacy customers that can't change this PR adds a few small utility functions and aligns AWS-LC with the behavior they expect from OpenSSL.

Call-outs:

I updated DES_set_key to perform the same checks as OpenSSL and updated internal usages to use DES_set_key_unchecked.

Testing:

Added new tests and ensured existing tests still pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.26%. Comparing base (772e22d) to head (e68d90e). Report is 2 commits behind head on main.

Files Patch % Lines
crypto/des/des.c 96.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1671 +/- ## ========================================== - Coverage 78.27% 78.26% -0.02% ========================================== Files 566 567 +1 Lines 95185 95224 +39 Branches 13664 13671 +7 ========================================== + Hits 74502 74523 +21 - Misses 20088 20107 +19 + Partials 595 594 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

torben-hansen commented 5 days ago

FYI mariadb_integration_* CI dimension breaks by this change