Closed samuel40791765 closed 1 day ago
Attention: Patch coverage is 0%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 78.22%. Comparing base (
e587bb5
) to head (54e7b32
). Report is 55 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
crypto/fipsmodule/ec/ec.c | 0.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues:
Addresses
CryptoAlg-1715
Description of changes:
Ruby exposes the
EC_GROUP
seed functions and allows you to set the seed withEC_GROUP_set_seed
. It's one thing that areEC_GROUP
s are static and immutable, but setting the seed is more prevalent to custom curves. We don't encourage using custom curves, so I've chose to mark it as a no-op and deprecated. We could arguably supportEC_GROUP_get0_seed
andEC_GROUP_get_seed_len
for our named curves, but the seed value is only used during the initial curve parameter generation. We've chosen to mark this as a no-op for now, implementing them creates additional complexity that doesn't really provide additional value to the consumer.Call-outs:
N/A
Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.