aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

Add EC seed functions as deprecated no-ops #1674

Closed samuel40791765 closed 1 day ago

samuel40791765 commented 4 days ago

Issues:

Addresses CryptoAlg-1715

Description of changes:

Ruby exposes the EC_GROUP seed functions and allows you to set the seed with EC_GROUP_set_seed. It's one thing that are EC_GROUPs are static and immutable, but setting the seed is more prevalent to custom curves. We don't encourage using custom curves, so I've chose to mark it as a no-op and deprecated. We could arguably support EC_GROUP_get0_seed and EC_GROUP_get_seed_len for our named curves, but the seed value is only used during the initial curve parameter generation. We've chosen to mark this as a no-op for now, implementing them creates additional complexity that doesn't really provide additional value to the consumer.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.22%. Comparing base (e587bb5) to head (54e7b32). Report is 55 commits behind head on main.

Files Patch % Lines
crypto/fipsmodule/ec/ec.c 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1674 +/- ## ========================================== + Coverage 78.09% 78.22% +0.12% ========================================== Files 562 566 +4 Lines 94656 95190 +534 Branches 13574 13664 +90 ========================================== + Hits 73923 74462 +539 + Misses 20140 20131 -9 - Partials 593 597 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.