search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
358 stars 111 forks source link

add ECPKParameters_print as no-op #1686

Closed samuel40791765 closed 2 months ago

samuel40791765 commented 3 months ago

Issues:

Resolves CryptoAlg-1715

Description of changes:

Ruby consumes ECPKParameters_print. The entire function is a bit convoluted and not really beneficial unless you're using custom curves. We can expose this as a no-op until there's a more proper use case for this.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.20%. Comparing base (622366f) to head (06b8672).

Files Patch % Lines
crypto/ec_extra/ec_asn1.c 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1686 +/- ## ======================================= Coverage 78.19% 78.20% ======================================= Files 571 571 Lines 95465 95467 +2 Branches 13704 13711 +7 ======================================= + Hits 74653 74662 +9 + Misses 20201 20193 -8 - Partials 611 612 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.