Enabling DIT flag in AArch64.

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.

Other

258 stars 105 forks source link

Issues:

Addresses CryptoAlg-2501

Description of changes:

Add a compile flag to enable it.
DIT APIs and macro are available for external use.
- Add the macro to Speed() commented out. That is where it was experimented with. Enabling it there make the benchmarks similar to not having DIT enabled. This is to suggest that the macro can be used by AWS-LC callers in their own scope around multiple calls to the library to improve the performance since DIT would not switch on and off at the entry/exit of the library functions.

Call-outs:

N/A

Testing:

A test is added to CI with the compile flag that enables DIT set to ON.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

Codecov Report

Attention: Patch coverage is 77.35849% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.23%. Comparing base (5a47ea1) to head (b02247a).

Files	Patch %	Lines
crypto/fipsmodule/dh/dh.c	75.00%	4 Missing :warning:
crypto/fipsmodule/evp/evp.c	0.00%	4 Missing :warning:
crypto/fipsmodule/rsa/rsa.c	81.81%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1687 +/- ## ========================================== - Coverage 78.26% 78.23% -0.04% ========================================== Files 567 567 Lines 95242 95265 +23 Branches 13673 13672 -1 ========================================== - Hits 74543 74531 -12 - Misses 20105 20138 +33 - Partials 594 596 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aws / aws-lc