search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
258 stars 105 forks source link

Make aes_hw_ctr32_encrypt_blocks (AArch64) handle len=0 correctly #1690

Open nebeid opened 4 days ago

nebeid commented 4 days ago

Issues:

Resolves #CryptoAlg-2498

Description of changes:

aes_hw_ctr32_encrypt_blocks encrypts (and writes to the output) 2 blocks when the input length is 0 blocks. The function is guarded wherever it's called by checks that len != 0. This change fixes this behaviour without taxing the performance.

Testing:

Tested the performance on Graviton3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.19%. Comparing base (bf992e7) to head (c32cbcd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1690 +/- ## ======================================= Coverage 78.19% 78.19% ======================================= Files 571 571 Lines 95458 95458 Branches 13705 13704 -1 ======================================= + Hits 74642 74643 +1 - Misses 20204 20205 +1 + Partials 612 610 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.