search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
398 stars 118 forks source link

Lower required Go version, add CI test for specific version #1725

Closed andrewhop closed 3 months ago

andrewhop commented 3 months ago

Description of changes:

Add back support for Go 1.17.13 which is used by NetOS. Fix a few language compatibility issues for interface{} and cmd struct. This change does not affect the integrity value of the FIPS module.

Testing:

This change adds a new CI test which uses Go 1.17.13.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

Co-authored-by: Sean McGrail mcgrails@amazon.com

Revert "Replace interface{} with any"

This reverts commit 6a90c15f3f901b90acb91fcb4c11cf4c5f3bcfff.
codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.09%. Comparing base (4e54dd8) to head (d19fe55).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## fips-NetOS-2024-06-11 #1725 +/- ## ========================================================= - Coverage 78.13% 78.09% -0.05% ========================================================= Files 562 562 Lines 94667 94667 Branches 13576 13585 +9 ========================================================= - Hits 73964 73926 -38 - Misses 20111 20147 +36 - Partials 592 594 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.