Closed justsmth closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.44%. Comparing base (
94f021b
) to head (7e4f381
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It's not recommended to use static CRT with DLL libraries, especially when CRT objects (such as FILE
) could be passed across the DLL boundary.
Description of changes:
CMAKE_MSVC_RUNTIME_LIBRARY
.Testing
I tested with both the Ninja and "Visual Studio 17 2022" generators.
Shared (not recommended, but technically possible)
Before
After
Static
Before
After
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.