search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
354 stars 111 forks source link

Add -text support to X509 tool, add Version tool #1773

Closed andrewhop closed 1 month ago

andrewhop commented 1 month ago

Description of changes:

Add the -text option to the X509 tool which prints a certificate's contents in a human readable format. Also add the version tool which only supports printing the basic version information.

Testing:

Added a new test for X509 -text with some minor caveats due to difference in between OpenSSL versions. I didn't add a test for the version as that will always be different:

AWS-LC:
OpenSSL 1.1.1 (compatible; AWS-LC 1.33.0)

OpenSSL:
OpenSSL 3.3.1 4 Jun 2024 (Library: OpenSSL 3.3.1 4 Jun 2024)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.31%. Comparing base (c9f6b6d) to head (97a4dfb).

Files Patch % Lines
tool-openssl/x509_test.cc 11.11% 8 Missing :warning:
tool-openssl/x509.cc 50.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1773 +/- ## ======================================= Coverage 78.30% 78.31% ======================================= Files 580 580 Lines 97002 97016 +14 Branches 13902 13903 +1 ======================================= + Hits 75960 75975 +15 + Misses 20422 20419 -3 - Partials 620 622 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.