search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
398 stars 118 forks source link

Update x509 tool to write all output to common BIO which is a file or stdout #1800

Closed andrewhop closed 2 months ago

andrewhop commented 2 months ago

Description of changes:

Previously only some output followed the user's request using -out to direct the output to a file. This change updates everything to use a common BIO which is stdout by default or the user provided file.

Testing:

Added new tests that test writing to a file directly with -out we have existing tests that cover writing to stdout (and then getting redirected to a file with >) works as expected.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (51890da) to head (0ba831d). Report is 17 commits behind head on main.

Files Patch % Lines
tool-openssl/x509_test.cc 0.00% 8 Missing :warning:
tool-openssl/x509.cc 85.71% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1800 +/- ## ========================================== - Coverage 78.34% 78.33% -0.01% ========================================== Files 581 581 Lines 97312 97339 +27 Branches 13949 13955 +6 ========================================== + Hits 76238 76251 +13 - Misses 20453 20466 +13 - Partials 621 622 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.