search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
399 stars 118 forks source link

[EC] Implement generic scalar multiplication #1982

Closed dkostic closed 6 days ago

dkostic commented 2 weeks ago

Issues:

Resolves #ISSUE-NUMBER1 Addresses #ISSUE-NUMBER2

Description of changes:

This change implements a generic scalar multiplication function that can work in four modes of operation which covers the three functions we need to implement: multiplication of an arbitrary point, of a base point, and the so-called public multiplication.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 59.32203% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.85%. Comparing base (c9d48a6) to head (1bf868b). Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
crypto/fipsmodule/ec/ec_nistp.c 52.94% 24 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1982 +/- ## ========================================== + Coverage 78.79% 78.85% +0.06% ========================================== Files 590 593 +3 Lines 101506 101977 +471 Branches 14401 14454 +53 ========================================== + Hits 79979 80414 +435 - Misses 20891 20918 +27 - Partials 636 645 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.