codecov-commenter
commented
1 week ago Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
Project coverage is 78.88%. Comparing base (
f0c9b3a) to head (e0e25a3).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| crypto/lhash/lhash.c | 0.00% | 3 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1987 +/- ## ========================================== - Coverage 78.89% 78.88% -0.01% ========================================== Files 593 593 Lines 101965 101968 +3 Branches 14458 14463 +5 ========================================== - Hits 80441 80436 -5 - Misses 20877 20886 +9 + Partials 647 646 -1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues:
Resolves
CryptoAlg-2449Description of changes:
This extends upon https://github.com/aws/aws-lc/pull/1986.
We do have all the necessary support for "LHASH", it's just been renamed and made internal by upstream: https://github.com/aws/aws-lc/commit/b8441aced4090488a31375af81c4f7e5014fe791. Ruby's CONF module happens to have a dependency on a couple of LHASH macros OpenSSL created and the non-opaqueness of
CONF. Although we aren't likely to be supporting CONF files for the time being, this change seems to reasonable for enough us to maintain so we can get a better build/patch for Ruby. We still fail most CONF related tests in Ruby, so we'll have to work around those. But this commit lets us gracefully build with the underlying C code for Ruby CONF without any AWS-LC specific logic.Call-outs:
N/A
Testing:
Verified that this passes the build for Ruby
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.