search

aws / aws-lc

AWS-LC is a general-purpose cryptographic library maintained by the AWS Cryptography team for AWS and their customers. It іs based on code from the Google BoringSSL project and the OpenSSL project.
Other
398 stars 118 forks source link

[EC] Unify scalar_mul_public for ec_nistp curves #2004

Open dkostic opened 2 days ago

dkostic commented 2 days ago

Issues:

CryptoAlg-2545

Description of changes:

Added unified scalar_mul_public implemented in ec_nistp. This is a refactor of the algorithm in p384.c and p521.c that makes it generic. The implementations in p384.c, p521.c, as well as in p256.c, are substituted with this new unified implementation.

Call-outs:

Builds on top of #2003

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

codecov-commenter commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.89%. Comparing base (ab8953b) to head (12c1aec). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2004 +/- ## ======================================= Coverage 78.89% 78.89% ======================================= Files 595 594 -1 Lines 102451 102380 -71 Branches 14527 14508 -19 ======================================= - Hits 80827 80772 -55 + Misses 20976 20958 -18 - Partials 648 650 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: