search

aws / aws-msk-iam-auth

Enables developers to use AWS Identity and Access Management (IAM) to connect to their Amazon Managed Streaming for Apache Kafka (Amazon MSK) clusters.
Apache License 2.0
138 stars 65 forks source link

feat: replace regions with v2 api #164

Closed jvdadda closed 1 week ago

jvdadda commented 2 months ago

Description of changes:

Replace the v1 region API with V2. I do not succeed to find an exact equivalent, so to try to extract the region from the host, I check if I find the region id in the string, and if not, fallback to the default region provider.

I removed the sdk V1 dependency that have remove few helper method (from transiant dependencies), I reimplemented them instead of adding an extra dependency.

It should end the V1 SDK, unit tests are green, I tested for my own case, it works, hoping it will for everyone

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Will resolve https://github.com/aws/aws-msk-iam-auth/issues/154

jvdadda commented 1 month ago

@sidyag And here is the last pull request that remove all java-sdk-v1 dependencies

ukby1234 commented 1 week ago

@sidyag friendly bump