search

aws / aws-mwaa-local-runner

This repository provides a command line interface (CLI) utility that replicates an Amazon Managed Workflows for Apache Airflow (MWAA) environment locally.
MIT No Attribution
672 stars 683 forks source link

FIX: `package-requirements` always returns exit code 0, even on failure #389

Open matthewbarreiro opened 1 month ago

matthewbarreiro commented 1 month ago

Issue #: Closes #388

Description of changes: Check the exit code for pip3 download -r ... in entrypoint.sh. If non-zero, exit with the same error code.

Note: This only solves one particular case. A more thorough solution would be to use something like set -e for all these "utility" commands (package-requirements,test-startup-script, etc). But I imagine that is a larger (and possibly internal) discussion.

If this change is accepted, I also request that it get merged to all lower environments (or at least all supported ones) as well. This bug exists in v2.2.2-v2.9.2.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

matthewbarreiro commented 2 weeks ago

Hi - would someone kindly take a look at this?

Thank you in advanced!