aws / aws-nitro-enclaves-cli

Tooling for Nitro Enclave Management
Apache License 2.0
121 stars 81 forks source link

Allocator service triggers EINVAL error in dmesg #397

Open sabin-rapan opened 2 years ago

sabin-rapan commented 2 years ago

This piece of code https://github.com/aws/aws-nitro-enclaves-cli/blame/main/bootstrap/nitro-enclaves-allocator#L129-L138 is called every time the allocator service is started.

It writes an empty string to /sys/module/nitro_enclaves/parameters/ne_cpus. The driver however doesn't know how to interpret this empty string (see https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/virt/nitro_enclaves/ne_misc_dev.c#n431) so it tries to allocate this invalid cpu pool, fails, then prints EINVAL to dmesg.

Everything works perfectly fine however, so no actual issue just that seeing errors in dmesg is super confusing when debugging other stuff.

Edit: this is not an issue with nitro-cli, just with the driver.