aws / aws-nitro-enclaves-cli

Tooling for Nitro Enclave Management
Apache License 2.0
120 stars 81 forks source link

replace private containers with public containers in tests #489

Closed petreeftime closed 1 year ago

petreeftime commented 1 year ago

In tests we were using a private container that was not possible to use without credentials owned by the aws-nitro-enclaves team. This commit uses instead a container image that is public, and should make running the tests on just a Nitro Enclaves instance easier.

There are still some issues with running tests, in the sense that the integration tests expect to be run after run_tests creates some enclave images and sets up the environment, but run_tests script expects to be able to do insmod and rmmod, which on standard Amazon Linux is not possible, since the module is built-in and cannot be replaced, so it will fail.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.