Open GrosQuildu opened 2 months ago
The command_executer/src/protocol_helpers.rs has a denial of service bug. The recv method may return 0 bytes (the size) variable, and this case is not accounted for: the 0 may be added to the recv_bytes infinitely.
recv
size
recv_bytes
Similar issue exists in vsock_sample: https://github.com/aws/aws-nitro-enclaves-samples/blob/dc4bba3d99bc4988a87ce7775cf1bc554537da16/vsock_sample/rs/src/protocol_helpers.rs#L45-L52
Correct handling is implemented in python versions and in the kmstool: https://github.com/aws/aws-nitro-enclaves-sdk-c/blob/550f7313bf792bf03200c7c6e1ac3fd7d2dc382f/bin/kmstool-enclave/main.c#L245-L247
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
The command_executer/src/protocol_helpers.rs has a denial of service bug. The
recvmethod may return 0 bytes (thesize) variable, and this case is not accounted for: the 0 may be added to therecv_bytesinfinitely.Similar issue exists in vsock_sample: https://github.com/aws/aws-nitro-enclaves-samples/blob/dc4bba3d99bc4988a87ce7775cf1bc554537da16/vsock_sample/rs/src/protocol_helpers.rs#L45-L52
Correct handling is implemented in python versions and in the kmstool: https://github.com/aws/aws-nitro-enclaves-sdk-c/blob/550f7313bf792bf03200c7c6e1ac3fd7d2dc382f/bin/kmstool-enclave/main.c#L245-L247
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.