Update eif_build command line experience

aws / aws-nitro-enclaves-image-format

This library provides the definition of the enclave image format (EIF) file used in AWS Nitro Enclaves.

Apache License 2.0

11 stars 16 forks source link

Update eif_build command line experience #27

Closed agraf closed 1 month ago

agraf commented 2 months ago

The eif_build command line utility was pretty dormant: No support for aarch64, no simple support to override metadata such as build time, no mention of the tool in the README. This PR extends the eif_build tool to become slightly more prominent and useful:

Aarch64 support (Thanks to Monzo!)
Remove old SHA support
Improve the result output (JSON prettified now!)
New command line options to override build metadata (build_time, build_tool, build_tool_version, img_os, img_kernel)
Make kernel_config parameter optional
Move eif_build from examples into its own build target
Add README

agraf commented 2 months ago

CC @Conan-Kudo 😄

Conan-Kudo commented 2 months ago

Does this now get built with cargo?

Conan-Kudo commented 2 months ago

Why is this an example if this is a reference tool to use?

agraf commented 2 months ago

Does this now get built with cargo?

Yes, if you build with cargo build --all or cargo build --workspace or cargo build -p eif_build, you get the eif_build tool as output.

Why is this an example if this is a reference tool to use?

I agree that it's awkward. I updated the Cargo.toml file to make it a separate stand alone target.