search

aws / aws-nitro-enclaves-nsm-api

This provides a library for interacting with the Nitro Secure Module, which provides Nitro Enclaves with attestation capability.
Apache License 2.0
62 stars 43 forks source link

Timestamps in AttestationDocs are incorrect #20

Closed exFalso closed 2 years ago

exFalso commented 2 years ago

The code clearly states that the timestamp should be seconds since epoch:

https://github.com/aws/aws-nitro-enclaves-nsm-api/blob/9ddb589875baf345d085a980aa96cf3a4e480ea8/nsm-io/src/lib.rs#L219-L220

However, in actual attestations we are seeing milliseconds since epoch being reported.

petreeftime commented 2 years ago

Milliseconds is correct, the docs need to be updated.

petreeftime commented 2 years ago

Fixed in #21